Fix spot export error for multiple grains #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple grains were being exported simultaneously due to
multiprocessing the
pull_spots()
function, a race condition wouldcause an error with this body of code:
Basically, two processes would both see at the same time that the
output directory does not exist, and then they would both try to
make it at the same time. One process would make the directory,
however, and then the second process would get a
FileExistsError
because the directory was already created.
To avoid the race condition, just modify the code to this:
This appears to fix the issue in my testing.
Fixes: HEXRD/hexrdgui#1192